Skip to content

Conversation

@atm1504
Copy link
Member

@atm1504 atm1504 commented Aug 23, 2019

Fixes #2350
Changes:

  • Add recaptcha for signup

Screenshots for the change:
Screenshot 2019-08-23 at 10 47 00 AM

@auto-label auto-label bot added the feature label Aug 23, 2019
private lateinit var forgotPasswordProgressDialog: Dialog
private lateinit var builder: AlertDialog.Builder
private var checkDialog: Boolean = false
private val RECAPTCHA_KEY = "6LcKhbMUAAAAAGFbYZeNFzqol-7EjOHUK5MvEeOE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ci-reporter
Copy link

ci-reporter bot commented Aug 24, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 9c4f090. Here's the output:

lint check
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for 1048cc2
lint check
> Task :app:preBuild UP-TO-DATE

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ci-reporter
Copy link

ci-reporter bot commented Aug 24, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 1048cc2. Here's the output:

lint check
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@atm1504
Copy link
Member Author

atm1504 commented Aug 24, 2019

@iamareebjamal please add the API key. The build is failing because it's not getting the key.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot keep the API key in the app itself. This would be a security issue. It should be added during building of the app using Travis environment variables. Please implement it in that way.

@iamareebjamal
Copy link
Member

Build should not fail if there is no API key

The feature should only enable in presence of the API key

@atm1504
Copy link
Member Author

atm1504 commented Aug 30, 2019

I will update it accordingly.

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

SafetyNet.getClient(this).verifyWithRecaptcha(RECAPTCHA_KEY)
.addOnSuccessListener(this, OnSuccessListener { response ->
val userResponseToken = response.tokenResult
Log.d("KHANKI", "Started recaptcha verification")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atm1504 Please remove this.

val stringPassword = password.editText?.text.toString()
val stringConfirmPassword = confirmPassword.editText?.text.toString()
val stringURL = inputUrlSignUp.editText?.text.toString()
Log.d("KHANKI", "Signned up")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atm1504 Please remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ReCaptcha for Signup attempt

4 participants